-
-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
herbe: init at 1.0.0 #107892
herbe: init at 1.0.0 #107892
Conversation
Result of 1 package built:
|
Result of 1 package built:
|
Result of |
Done, and squashed. |
It looks like |
Result of 1 package built:
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
@wishfort36 can you add support to patches? |
1205094
to
459e234
Compare
@AndersonTorres: Consider it done. I'm looking at st's default.nix and am thinking. Could it be a good idea to have an
and rebuilding, but it doesn't exactly feel "correct" per se. I guess the same would go for overriding the |
IMO, if the common way to extend this program is using |
It's a good idea to me. This is a "standard" approach to softwares configured by patches, indeed. |
I've been under the impression that this:
would be sufficient, but if I do that and modify my
then compilation fails, complaining that it can't "find" the xrandr header file, as if |
@wishfort36 If you're using In this case you want to (sorry if this is wrong, I am doing it by head, I may forgetting something): {
packageOverrides = pkgs: rec {
herbe = pkgs.herbe.override ({
patches = [ /home/wishfort36/21.diff ];
extraLibs = with pkgs; [ xorg.libXrandr ];
});
};
} |
Thanks! That worked. I've also pushed the |
Result of 1 package built:
|
Motivation for this change
This program displays notifications without including a daemon or the whole D-Bus dependency tree.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)